Fix haproxy-nbthread ghe-config key in release notes#43533
Fix haproxy-nbthread ghe-config key in release notes#43533djdefi wants to merge 1 commit intogithub:mainfrom
Conversation
The ghe-config key requires the core. prefix: ghe-config core.haproxy-nbthread (not ghe-config haproxy-nbthread) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
bot
added
the
triage
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. This pull request contains code changes, so we will not generate a table of review links. 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Pull request overview
Updates GitHub Enterprise Server release notes to correct the ghe-config key used to override HAProxy thread count, preventing admins from running an invalid command.
Changes:
- Replace
ghe-config haproxy-nbthreadwithghe-config core.haproxy-nbthreadin GHES 3.16.16, 3.17.13, 3.18.7, and 3.19.4 release notes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| data/release-notes/enterprise-server/3-16/16.yml | Corrects HAProxy nbthread ghe-config key in the 3.16.16 release note. |
| data/release-notes/enterprise-server/3-17/13.yml | Corrects HAProxy nbthread ghe-config key in the 3.17.13 release note. |
| data/release-notes/enterprise-server/3-18/7.yml | Corrects HAProxy nbthread ghe-config key in the 3.18.7 release note. |
| data/release-notes/enterprise-server/3-19/4.yml | Corrects HAProxy nbthread ghe-config key in the 3.19.4 release note. |
| changes: | ||
| - | | ||
| To improve performance on large instances, HAProxy automatically scales its thread count based on available CPUs and uses higher connection limits for high-traffic backend services including GitHub Actions, database connections, job queues, and package registry. Administrators can override the thread count using `ghe-config haproxy-nbthread` if needed. | ||
| To improve performance on large instances, HAProxy automatically scales its thread count based on available CPUs and uses higher connection limits for high-traffic backend services including GitHub Actions, database connections, job queues, and package registry. Administrators can override the thread count using `ghe-config core.haproxy-nbthread` if needed. |
There was a problem hiding this comment.
This fixes the command for these four patch versions, but the repo still contains the old (likely incorrect) ghe-config haproxy-nbthread text in several other Enterprise Server release notes (for example: data/release-notes/enterprise-server/3-19/3.yml, 3-18/6.yml, 3-17/12.yml, 3-16/15.yml, 3-15/20.yml, 3-14/25.yml). If the correct key is consistently core.haproxy-nbthread, consider updating all remaining occurrences so users reading other patch release notes don’t copy an invalid command.
|
Closing — opened in error. Will resubmit through the proper internal channel. |
The HAProxy nbthread release note in 3.16.16, 3.17.13, 3.18.7, and 3.19.4 says
ghe-config haproxy-nbthreadbut the correct command isghe-config core.haproxy-nbthread(needs thecore.prefix).Without the prefix, admins running the command will get an error or set the wrong config key.