chore: add no-source-scanning test rule to CLAUDE.md#1130
Merged
Conversation
billxinli
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.toContain('pattern'))Test plan
Note
Low Risk
Low risk; this PR only updates developer documentation with testing guidance and does not change runtime code or test execution.
Overview
Adds a new “Test Style — Functional Over Source Scanning” section to
CLAUDE.mdthat explicitly forbids tests which read source files and assert on string patterns (e.g.,.toContain('pattern')).Updates the testing guidance to steer contributors toward behavior-based functional tests, integration tests for built binaries, and unit tests that call real functions.
Written by Cursor Bugbot for commit c558ec6. Configure here.