fix(build): deduplicate shared deps across external bundles#110
Merged
fix(build): deduplicate shared deps across external bundles#110
Conversation
Update picomatch dep from 2.3.1 to 4.0.4 and override from 4.0.3 to 4.0.4. Make runWithTempDir prefix parameter optional with default.
Mark signal-exit, supports-color, debug, which, spdx-correct, spdx-expression-parse, and p-map as external in npm-pack bundle so they resolve to existing standalone wrappers at runtime. Mark supports-color external in debug bundle. Add p-map as standalone bundle and externalize from pico-pack. Update supports-color 10.0.0 → 10.2.2. Add p-map 7.0.4 to devDependencies and pnpm overrides. Enhance force-node-modules esbuild plugin to handle ESM-only packages. Net savings: ~88KB across bundles (npm-pack -86KB, debug -6KB, pico-pack -4KB, p-map +8KB new).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm buildpasses (145 files validated, 48 external modules verified)pnpm testpasses (6370 tests, 143 test files)pnpm run check --allpassespnpm run fix --allpasses🤖 Generated with Claude Code