fix(@angular/build): ensure Vitest mock patching is executed only once#32877
Merged
clydin merged 1 commit intoangular:mainfrom Mar 27, 2026
Merged
fix(@angular/build): ensure Vitest mock patching is executed only once#32877clydin merged 1 commit intoangular:mainfrom
clydin merged 1 commit intoangular:mainfrom
Conversation
Wrap the Vitest mocking overrides in a global guard to prevent repeated execution in shared environments or watch mode runs.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Vitest mock patching logic in the Angular build system to prevent multiple applications of the patch. It introduces a global symbol check on globalThis to ensure the vi.mock methods are only wrapped once. I have no feedback to provide.
1 task
alan-agius4
approved these changes
Mar 27, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the Vitest mocking overrides in a global guard to prevent repeated execution in shared environments or watch mode runs.