Skip to content

[hotfix] [runtime/tests] Wait for clock advance in BlobServerCleanupTest#27803

Open
lurui1997 wants to merge 1 commit intoapache:masterfrom
lurui1997:hotfix/blob-transient-cleanup-wait-clock
Open

[hotfix] [runtime/tests] Wait for clock advance in BlobServerCleanupTest#27803
lurui1997 wants to merge 1 commit intoapache:masterfrom
lurui1997:hotfix/blob-transient-cleanup-wait-clock

Conversation

@lurui1997
Copy link

What is the purpose of the change

Replace fixed Thread.sleep(1) with CommonTestUtils.waitUntilCondition so the test waits until the wall clock actually moves to a new millisecond. This reduces timing assumptions on slow or heavily loaded CI agents while preserving the original intent (separate access timestamps for transient blob expiry assertions).

Brief change log

  • BlobServerCleanupTest: wait for currentTimeMillis() > snapshot instead of a 1 ms sleep (two places)
  • Widen test method throws to Exception because waitUntilCondition declares it

Verifying this change

This change is already covered by existing tests: BlobServerCleanupTest (same scenarios).

Local verification (optional): mvn -pl flink-runtime -Dtest=BlobServerCleanupTest test

Does this pull request potentially affect one of the following parts:

  • Dependencies: no
  • The public API: no
  • The serializers: no
  • The runtime per-record code paths: no
  • Deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

Made with Cursor

@lurui1997
Copy link
Author

If CI shows unrelated flakes elsewhere, this PR only touches BlobServerCleanupTest. I can run additional Maven modules on request.

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 22, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants