[hotfix] [runtime/tests] Wait for clock advance in BlobServerCleanupTest#27803
Open
lurui1997 wants to merge 1 commit intoapache:masterfrom
Open
[hotfix] [runtime/tests] Wait for clock advance in BlobServerCleanupTest#27803lurui1997 wants to merge 1 commit intoapache:masterfrom
lurui1997 wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
If CI shows unrelated flakes elsewhere, this PR only touches |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Replace fixed
Thread.sleep(1)withCommonTestUtils.waitUntilConditionso the test waits until the wall clock actually moves to a new millisecond. This reduces timing assumptions on slow or heavily loaded CI agents while preserving the original intent (separate access timestamps for transient blob expiry assertions).Brief change log
BlobServerCleanupTest: wait forcurrentTimeMillis() > snapshotinstead of a 1 ms sleep (two places)ExceptionbecausewaitUntilConditiondeclares itVerifying this change
This change is already covered by existing tests:
BlobServerCleanupTest(same scenarios).Local verification (optional):
mvn -pl flink-runtime -Dtest=BlobServerCleanupTest testDoes this pull request potentially affect one of the following parts:
Documentation
Made with Cursor