fix: add onError handler for extracting-queries state#39387
Open
Alearner12 wants to merge 1 commit intogatsbyjs:masterfrom
Open
fix: add onError handler for extracting-queries state#39387Alearner12 wants to merge 1 commit intogatsbyjs:masterfrom
Alearner12 wants to merge 1 commit intogatsbyjs:masterfrom
Conversation
Fixes gatsbyjs#39294 The extractingQueries state in the query-running state machine was missing an onError handler, causing confusing 'Missing onError handler for invocation extracting-queries' errors when schema validation fails. This commonly occurs when using gatsby-source-wordpress with WooGraphQL where certain connection types don't implement required interface fields. Added test to verify error handling works correctly.
gatsbot
bot
added
the
status: triage needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39294
Problem
The
extractingQueriesstate in the query-running state machine was missing anonErrorhandler, causing confusing "Missing onError handler for invocation 'extracting-queries'" errors when schema validation fails.This commonly occurs when using
gatsby-source-wordpresswith WooGraphQL where certain connection types (likeWpProductToPaCombustivelConnectionType) don't implement required interface fields (nodes,pageInfo).Solution
Added an
onErrorhandler to theextractingQueriesstate that gracefully transitions to thedonestate when an error occurs. The actual error is still reported by theextractQueriesservice viapanicOnBuild, but now the state machine won't crash with the confusing "Missing onError handler" message.Testing
Added a test case to verify error handling works correctly during query extraction.