feat(nuxt): Add middleware instrumentation compatibility for Nuxt 5#19968
Open
feat(nuxt): Add middleware instrumentation compatibility for Nuxt 5#19968
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Nuxt
Other
Bug Fixes 🐛Cloudflare
Core
Deps
Other
Internal Changes 🔧Deps Dev
Nuxt
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
4c21106 to
d69a90e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nitro v3 (used by Nuxt 5) ships with h3 v2, which restructures the
EventHandlerObjecttype (old / new). The previousonRequest/onBeforeResponselifecycle hooks are replaced by a single middleware array, andhandleris now optional.This PR updates the Nuxt SDK's middleware instrumentation to handle both shapes transparently: h3 v1 (
onRequest,onBeforeResponse, requiredhandler) for Nuxt 4 / Nitro v2, and h3 v2 (middleware[], optionalhandler) for Nuxt 5 / Nitro v3.The Nuxt 5 test app middleware files are updated to match the new h3 v2 API, and unit/E2E test assertions are adjusted accordingly.
Closes #19954