ref(core): Consolidate getOperationName into one shared utility#19971
Merged
nicohrubec merged 5 commits intodevelopfrom Mar 26, 2026
Merged
ref(core): Consolidate getOperationName into one shared utility#19971nicohrubec merged 5 commits intodevelopfrom
nicohrubec merged 5 commits intodevelopfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Other
Bug Fixes 🐛Cloudflare
Core
Deps
Other
Internal Changes 🔧Core
Deps Dev
Nuxt
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
nicohrubec
force-pushed
the
nh/get-operation-name-consolidation
branch
from
4649131 to
1a368b1
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
JPeer264
approved these changes
Mar 26, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
looks cleaner and has less overhead. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have this function in both the shared utilities (used by
google-genaiandanthropic) and inopenaiwith slightly different names for no apparent reason. We also had a separate helper that just prependsgen_aito the operation name in both cases, which seems unnecessary. Doing some cleanup hereCloses #19978 (added automatically)