Skip to content

ref(openai): Move input handling code into API-specific functions#5687

Merged
alexander-alderman-webb merged 6 commits intomasterfrom
webb/openai/remove-common-input-data
Mar 26, 2026
Merged

ref(openai): Move input handling code into API-specific functions#5687
alexander-alderman-webb merged 6 commits intomasterfrom
webb/openai/remove-common-input-data

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Mar 18, 2026

Description

Inline code from _commmon_set_input_data() to remove dead code in follow up PRs.

Issues

Reminders

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Langchain

  • Set gen_ai.operation.name and gen_ai.pipeline.name on LLM spans by ericapisani in #5849
  • Broaden AI provider detection beyond OpenAI and Anthropic by ericapisani in #5707
  • Update LLM span operation to gen_ai.generate_text by ericapisani in #5796

Internal Changes 🔧

Langchain

  • Add text completion test by alexander-alderman-webb in #5740
  • Add tool execution test by alexander-alderman-webb in #5739
  • Add basic agent test with Responses call by alexander-alderman-webb in #5726
  • Replace mocks with httpx types by alexander-alderman-webb in #5724
  • Consolidate span origin assertion by alexander-alderman-webb in #5723
  • Consolidate available tools assertion by alexander-alderman-webb in #5721

Other

  • (openai) Move input handling code into API-specific functions by alexander-alderman-webb in #5687
  • Temporarily stop running litellm tests by alexander-alderman-webb in #5851

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

Codecov Results 📊

13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 6.73s

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 14438 uncovered lines.

Files with missing lines (1)
File Patch % Lines
openai.py 4.45% ⚠️ 623 Missing

Generated by Codecov Action

@github-actions
Copy link
Contributor

Codecov Results 📊

49 passed | ⏭️ 3 skipped | Total: 52 | Pass Rate: 94.23% | Execution Time: 12.35s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 1.39%. Project has 14964 uncovered lines.
❌ Project coverage is 27.21%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
openai.py 9.24% ⚠️ 589 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    27.23%    27.21%    -0.02%
==========================================
  Files          189       189         —
  Lines        20508     20557       +49
  Branches      6706      6746       +40
==========================================
+ Hits          5585      5593        +8
- Misses       14923     14964       +41
- Partials       487       490        +3

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb merged commit f193226 into master Mar 26, 2026
158 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/openai/remove-common-input-data branch March 26, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants