Skip to content

C++: Silence ExtractionRecoverableWarnings when BMN is active #21588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jketema wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Draft

C++: Silence ExtractionRecoverableWarnings when BMN is active #21588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cpp/ql/src/Diagnostics/ExtractionProblems.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ private newtype TExtractionProblem =
/**
* Superclass for the extraction problem hierarchy.
*/
class ExtractionProblem extends TExtractionProblem {
abstract class ExtractionProblem extends TExtractionProblem {
/** Gets the string representation of the problem. */
string toString() { none() }

Expand All @@ -65,6 +65,9 @@ class ExtractionProblem extends TExtractionProblem {

/** Gets the SARIF severity of this problem. */
int getSeverity() { none() }

/** Gets the `Compilation` the problem is associated with. */
abstract Compilation getCompilation();
}

/**
Expand Down Expand Up @@ -96,6 +99,8 @@ class ExtractionUnrecoverableError extends ExtractionProblem, TCompilationFailed
// [errors](https://docs.oasis-open.org/sarif/sarif/v2.1.0/csprd01/sarif-v2.1.0-csprd01.html#_Toc10541338).
result = 2
}

override Compilation getCompilation() { result = c }
}

/**
Expand All @@ -122,6 +127,8 @@ class ExtractionRecoverableWarning extends ExtractionProblem, TReportableWarning
// [warnings](https://docs.oasis-open.org/sarif/sarif/v2.1.0/csprd01/sarif-v2.1.0-csprd01.html#_Toc10541338).
result = 1
}

override Compilation getCompilation() { result = err.getCompilation() }
}

/**
Expand All @@ -148,4 +155,6 @@ class ExtractionUnknownProblem extends ExtractionProblem, TUnknownProblem {
// [warnings](https://docs.oasis-open.org/sarif/sarif/v2.1.0/csprd01/sarif-v2.1.0-csprd01.html#_Toc10541338).
result = 1
}

override Compilation getCompilation() { result = err.getCompilation() }
}
4 changes: 3 additions & 1 deletion cpp/ql/src/Diagnostics/ExtractionWarnings.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import ExtractionProblems

from ExtractionProblem warning
where
warning instanceof ExtractionRecoverableWarning and exists(warning.getFile().getRelativePath())
warning instanceof ExtractionRecoverableWarning and
exists(warning.getFile().getRelativePath()) and
not warning.getCompilation().buildModeNone()
or
warning instanceof ExtractionUnknownProblem
select warning,
Expand Down
Loading