C#: Update integration tests to use SDK 10.0.201.#21589
Merged
michaelnebel merged 1 commit intogithub:mainfrom Mar 26, 2026
Merged
C#: Update integration tests to use SDK 10.0.201.#21589michaelnebel merged 1 commit intogithub:mainfrom
michaelnebel merged 1 commit intogithub:mainfrom
Conversation
michaelnebel
force-pushed
the
csharp/updateintegrationtests
branch
from
ce61a95 to
1d0f049
Compare
michaelnebel
force-pushed
the
csharp/updateintegrationtests
branch
from
1d0f049 to
1a4f333
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates C# integration tests to consistently run under .NET SDK 10.0.201, avoiding runner-dependent SDK selection that changes Razor/CSHTML generated file locations and causes flaky expected-output comparisons.
Changes:
- Bump multiple integration-test
global.jsonfiles from10.0.100(and one from6.0.418) to10.0.201 - Refresh expected-output baselines (
*.expected) to match SDK10.0.201behavior (updated ref pack versions, compiler args, and Razor generated paths)
Reviewed changes
Copilot reviewed 65 out of 65 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| csharp/ql/integration-tests/windows/standalone_dependencies/global.json | Pin Windows standalone-deps integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/warn_as_error/global.json | Pin POSIX warn-as-error integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_versions/global.json | Pin NuGet-versions integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_no_sources/proj/global.json | Pin NuGet-no-sources integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_fallback/global.json | Pin NuGet-config-fallback integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error_timeout/global.json | Pin NuGet-config-timeout integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error/global.json | Pin NuGet-config-error integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget/global.json | Pin NuGet integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget with_space/global.json | Pin NuGet (path-with-space) integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_no_framework/global.json | Pin no-framework integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_multi_target/global.json | Pin multi-target integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies_multi_target/Assemblies.expected | Update multi-target assembly baseline for SDK 10.0.201 (ref pack version/path changes) |
| csharp/ql/integration-tests/posix/standalone_dependencies_multi_project/global.json | Pin multi-project integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies/global.json | Pin standalone-deps integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/standalone_dependencies/Assemblies.expected | Update standalone-deps assembly baseline for SDK 10.0.201 |
| csharp/ql/integration-tests/posix/inherit-env-vars/global.json | Pin inherit-env-vars integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/dotnet_test_mstest/global.json | Pin dotnet test (mstest) integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/posix/dotnet_test/global.json | Pin dotnet test integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/linux/standalone_dependencies_non_utf8_filename/global.json | Pin non-UTF8 filename integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/linux/diag_nuget_config_casing/global.json | Pin diag NuGet config-casing integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/linux/compiler_args/global.json | Pin compiler-args integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/linux/compiler_args/CompilerArgs.expected | Update compiler-args baseline for SDK 10.0.201 (nowarn + pack/analyzer paths) |
| csharp/ql/integration-tests/all-platforms/standalone_winforms/global.json | Pin winforms integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/standalone_winforms/Assemblies.expected | Update winforms assembly baseline for SDK 10.0.201 (windowsdesktop ref pack version/path changes) |
| csharp/ql/integration-tests/all-platforms/standalone_slnx/global.json | Pin slnx integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/standalone_resx/global.json | Pin resx integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/standalone_failed/global.json | Pin standalone-failed integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/standalone_dependency_dir/proj/global.json | Pin dependency-dir integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/standalone_dependencies_net48/global.json | Pin net48 standalone-deps integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/standalone_buildless_option/global.json | Pin buildless-option integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/standalone/global.json | Pin standalone integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/source_generator/global.json | Pin source-generator integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/dotnet_run/global.json | Pin dotnet run integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/dotnet_publish/global.json | Pin dotnet publish integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/dotnet_pack/global.json | Pin dotnet pack integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/dotnet_no_args_inject/global.json | Pin no-args-inject integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/dotnet_build/global.json | Pin dotnet build integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/dotnet_10/global.json | Pin dotnet_10 integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/diag_recursive_generics/global.json | Pin diag recursive-generics integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/diag_missing_xamarin_sdk/global.json | Pin diag missing-xamarin-sdk integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/diag_missing_project_files/global.json | Pin diag missing-project-files integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/diag_dotnet_incompatible/global.json | Pin diag dotnet-incompatible integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/cshtml_standalone_net6/global.json | Switch cshtml standalone “net6” test to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/cshtml_standalone_net6/Files.expected | Update Razor generated file path baseline for SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/cshtml_standalone_flowsteps/global.json | Pin cshtml flowsteps integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/cshtml_standalone_disabled/global.json | Pin cshtml disabled integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/cshtml_standalone/global.json | Pin cshtml standalone integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/cshtml_standalone/Files.expected | Update Razor generated file path baseline for SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/cshtml/global.json | Pin cshtml integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/cshtml/Files.expected | Update Razor generated file path baseline for SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/conditional_compilation/global.json | Pin conditional-compilation integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/blazor_build_mode_none/global.json | Pin Blazor (build mode none) integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/blazor_build_mode_none/XSS.expected | Update Blazor XSS baseline for SDK 10.0.201 (Razor output path changes) |
| csharp/ql/integration-tests/all-platforms/blazor_build_mode_none/Files.expected | Update Blazor file baseline for SDK 10.0.201 (Razor output path changes) |
| csharp/ql/integration-tests/all-platforms/blazor_build_mode_none/BlazorTest/global.json | Pin nested Blazor test project to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/blazor/global.json | Pin Blazor integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/blazor/XSS.expected | Update Blazor XSS baseline for SDK 10.0.201 (Razor output path changes) |
| csharp/ql/integration-tests/all-platforms/blazor/Files.expected | Update Blazor file baseline for SDK 10.0.201 (Razor output path changes) |
| csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/global.json | Pin nested Blazor test project to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/binlog_multiple/global.json | Pin binlog-multiple integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/binlog/global.json | Pin binlog integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/autobuild_slnx/global.json | Pin autobuild slnx integration tests to SDK 10.0.201 |
| csharp/ql/integration-tests/all-platforms/autobuild/global.json | Pin autobuild integration tests to SDK 10.0.201 |
Comments suppressed due to low confidence (1)
csharp/ql/integration-tests/all-platforms/standalone/global.json:1
- The
global.jsonfiles pin an SDK version but do not specify arollForwardpolicy. To reduce runner-to-runner variability (and make intent explicit), consider adding arollForwardsetting (e.g.,latestPatchto allow servicing updates within the same band, ordisableif CI always installs the exact SDK). Applying this consistently across the integration-testglobal.jsonfiles makes SDK resolution behavior more predictable.
| { | ||
| "sdk": { | ||
| "version": "6.0.418" | ||
| "version": "10.0.201" |
There was a problem hiding this comment.
This test folder is explicitly named cshtml_standalone_net6, but it now pins the SDK to 10.0.201 (previously 6.0.418). If this test is meant to validate .NET 6-era Razor/CSHTML behavior, consider keeping the 6.x SDK here (or renaming the test folder/test to reflect that it now runs under .NET 10), to avoid confusion and unintended coverage changes.
Suggested change
| "version": "10.0.201" | |
| "version": "6.0.418" |
Contributor
Author
There was a problem hiding this comment.
This is on purpose.
mbg
previously requested changes
Mar 26, 2026
Member
mbg
left a comment
mbg
left a comment
There was a problem hiding this comment.
Copilot's comment is correct -- also see my comment on the internal PR.
| { | ||
| "sdk": { | ||
| "version": "6.0.418" | ||
| "version": "10.0.201" |
michaelnebel
dismissed
mbg’s stale review
The .NET version was updated on purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that SDK 10.0.201 is installed on some of the runners, which causes spurious test failures. It appears that version 10.0.201 changes the location of CSHTML and RAZOR generated source files.