Update email preferences instructions with warning#43249
Update email preferences instructions with warning#43249kendoki wants to merge 1 commit intogithub:mainfrom
Conversation
Added a warning about removing old email addresses affecting commit associations.
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
@Kenshiro-sama Thanks for opening a PR! I don't have any major objections to having this warning here, since I know people can sometimes get intense about their contribution graphs, but I'm checking in with the rest of the team to make sure no one else has an objection that didn't occur to me. |
|
@kendoki I asked the rest of the team about this, and they feel that the warning is unnecessary. We have a section in the troubleshooting article about it, and if someone wants their graph to be accurate more than they want an updated email address, the fix is simple enough - they just have to re-add the old email. Since it's easy to fix, the rest of the team doesn't want to clutter the current article with additional notes. I'm afraid I'm not going to be able to accept this submission for that reason. |
Added a warning about removing old email addresses affecting commit associations.
Why:
Users may remove an old email address from their account without realizing that commits made with that email may no longer be associated with their profile. When this happens, those commits may stop appearing in the user's contribution graph.
This behavior is not currently mentioned in the documentation for changing the primary email address, which can lead to confusion or accidental loss of visible contribution history.
Closes: N/A
What's being changed (if available, include any code snippets, screenshots, or gifs):
This pull request adds a warning note before the step that instructs users to remove an old email address.
The warning explains that removing an email address used in previous commits may cause those commits to no longer be associated with the user’s account or appear in their contribution graph. It also advises users to ensure their commits are linked to another verified email before removing the address.
Check off the following: