Skip to content

fix: align qmd_index test assertion with ERR_CONFIG error message prefix #22671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Mar 24, 2026
Merged

fix: align qmd_index test assertion with ERR_CONFIG error message prefix #22671

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7cd7b2
Initial plan
Copilot Mar 24, 2026
4c00e70
fix: update qmd_index test to match ERR_CONFIG error message prefix
Copilot Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actions/setup/js/qmd_index.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe("qmd_index.cjs", () => {
// ── Error path: missing config ─────────────────────────────────────────────
it("fails when QMD_CONFIG_JSON is not set", async () => {
await runMain(undefined);
expect(mockCore.setFailed).toHaveBeenCalledWith("QMD_CONFIG_JSON environment variable not set");
expect(mockCore.setFailed).toHaveBeenCalledWith("ERR_CONFIG: QMD_CONFIG_JSON environment variable not set");
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion hard-codes the error code prefix string. To keep tests aligned with the central source of truth (and consistent with other tests in this repo), import ERR_CONFIG from ./error_codes.cjs and build the expected message using that constant (e.g., ${ERR_CONFIG}: ...).

Copilot uses AI. Check for mistakes.
expect(mockStore.update).not.toHaveBeenCalled();
});

Expand Down
Loading