Skip to content

add initial prompt stuff#1

Merged
Harrison Chase (hwchase17) merged 2 commits intomasterfrom
harrison/prompt
Oct 17, 2022
Merged

add initial prompt stuff#1
Harrison Chase (hwchase17) merged 2 commits intomasterfrom
harrison/prompt

Conversation

@hwchase17
Copy link
Contributor

No description provided.

@hwchase17 Harrison Chase (hwchase17) merged commit b6c215e into master Oct 17, 2022
@hwchase17 Harrison Chase (hwchase17) deleted the harrison/prompt branch October 21, 2022 20:11
Ivan Vendrov (ivendrov) pushed a commit to ivendrov/langchain that referenced this pull request Feb 14, 2023
Harrison Chase (hwchase17) pushed a commit that referenced this pull request Mar 27, 2023
Harrison Chase (hwchase17) pushed a commit that referenced this pull request Apr 22, 2023
Harrison Chase (hwchase17) pushed a commit that referenced this pull request Apr 27, 2023
without --no-sandbox param, load documents from url by selenium in
chrome occured error below:

```Traceback (most recent call last):
  File "/data//playgroud/try_langchain.py", line 343, in <module>
    langchain_doc_loader()
  File "/data//playgroud/try_langchain.py", line 67, in langchain_doc_loader
    documents = loader.load()
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 102, in load
    driver = self._get_driver()
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 76, in _get_driver
    return Chrome(options=chrome_options)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chrome/webdriver.py", line 80, in __init__
    super().__init__(
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chromium/webdriver.py", line 104, in __init__
    super().__init__(
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 286, in __init__
    self.start_session(capabilities, browser_profile)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 378, in start_session
    response = self.execute(Command.NEW_SESSION, parameters)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 440, in execute
    self.error_handler.check_response(response)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py", line 245, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: unknown error: Chrome failed to start: exited abnormally.
  (unknown error: DevToolsActivePort file doesn't exist)
  (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
Stacktrace:
#0 0x55cf8da1bfe3 <unknown>
#1 0x55cf8d75ad36 <unknown>
#2 0x55cf8d783b20 <unknown>
#3 0x55cf8d77fa9b <unknown>
#4 0x55cf8d7c1af7 <unknown>
#5 0x55cf8d7c111f <unknown>
#6 0x55cf8d7b8693 <unknown>
#7 0x55cf8d78b03a <unknown>
#8 0x55cf8d78c17e <unknown>
#9 0x55cf8d9dddbd <unknown>
#10 0x55cf8d9e1c6c <unknown>
#11 0x55cf8d9eb4b0 <unknown>
#12 0x55cf8d9e2d63 <unknown>
#13 0x55cf8d9b5c35 <unknown>
#14 0x55cf8da06138 <unknown>
#15 0x55cf8da062c7 <unknown>
#16 0x55cf8da14093 <unknown>
#17 0x7f3da31a72de start_thread
```

add option `chrome_options.add_argument("--no-sandbox")` for chrome.
VowelParrot (vowelparrot) pushed a commit that referenced this pull request Apr 28, 2023
without --no-sandbox param, load documents from url by selenium in
chrome occured error below:

```Traceback (most recent call last):
  File "/data//playgroud/try_langchain.py", line 343, in <module>
    langchain_doc_loader()
  File "/data//playgroud/try_langchain.py", line 67, in langchain_doc_loader
    documents = loader.load()
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 102, in load
    driver = self._get_driver()
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 76, in _get_driver
    return Chrome(options=chrome_options)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chrome/webdriver.py", line 80, in __init__
    super().__init__(
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chromium/webdriver.py", line 104, in __init__
    super().__init__(
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 286, in __init__
    self.start_session(capabilities, browser_profile)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 378, in start_session
    response = self.execute(Command.NEW_SESSION, parameters)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 440, in execute
    self.error_handler.check_response(response)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py", line 245, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: unknown error: Chrome failed to start: exited abnormally.
  (unknown error: DevToolsActivePort file doesn't exist)
  (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
Stacktrace:
#0 0x55cf8da1bfe3 <unknown>
#1 0x55cf8d75ad36 <unknown>
#2 0x55cf8d783b20 <unknown>
#3 0x55cf8d77fa9b <unknown>
#4 0x55cf8d7c1af7 <unknown>
#5 0x55cf8d7c111f <unknown>
#6 0x55cf8d7b8693 <unknown>
#7 0x55cf8d78b03a <unknown>
#8 0x55cf8d78c17e <unknown>
#9 0x55cf8d9dddbd <unknown>
#10 0x55cf8d9e1c6c <unknown>
#11 0x55cf8d9eb4b0 <unknown>
#12 0x55cf8d9e2d63 <unknown>
#13 0x55cf8d9b5c35 <unknown>
#14 0x55cf8da06138 <unknown>
#15 0x55cf8da062c7 <unknown>
#16 0x55cf8da14093 <unknown>
#17 0x7f3da31a72de start_thread
```

add option `chrome_options.add_argument("--no-sandbox")` for chrome.
Sam Ching (samching) pushed a commit to samching/langchain that referenced this pull request May 1, 2023
without --no-sandbox param, load documents from url by selenium in
chrome occured error below:

```Traceback (most recent call last):
  File "/data//playgroud/try_langchain.py", line 343, in <module>
    langchain_doc_loader()
  File "/data//playgroud/try_langchain.py", line 67, in langchain_doc_loader
    documents = loader.load()
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 102, in load
    driver = self._get_driver()
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 76, in _get_driver
    return Chrome(options=chrome_options)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chrome/webdriver.py", line 80, in __init__
    super().__init__(
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chromium/webdriver.py", line 104, in __init__
    super().__init__(
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 286, in __init__
    self.start_session(capabilities, browser_profile)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 378, in start_session
    response = self.execute(Command.NEW_SESSION, parameters)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 440, in execute
    self.error_handler.check_response(response)
  File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py", line 245, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: unknown error: Chrome failed to start: exited abnormally.
  (unknown error: DevToolsActivePort file doesn't exist)
  (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
Stacktrace:
#0 0x55cf8da1bfe3 <unknown>
langchain-ai#1 0x55cf8d75ad36 <unknown>
langchain-ai#2 0x55cf8d783b20 <unknown>
langchain-ai#3 0x55cf8d77fa9b <unknown>
langchain-ai#4 0x55cf8d7c1af7 <unknown>
langchain-ai#5 0x55cf8d7c111f <unknown>
langchain-ai#6 0x55cf8d7b8693 <unknown>
langchain-ai#7 0x55cf8d78b03a <unknown>
langchain-ai#8 0x55cf8d78c17e <unknown>
langchain-ai#9 0x55cf8d9dddbd <unknown>
langchain-ai#10 0x55cf8d9e1c6c <unknown>
langchain-ai#11 0x55cf8d9eb4b0 <unknown>
langchain-ai#12 0x55cf8d9e2d63 <unknown>
langchain-ai#13 0x55cf8d9b5c35 <unknown>
langchain-ai#14 0x55cf8da06138 <unknown>
langchain-ai#15 0x55cf8da062c7 <unknown>
langchain-ai#16 0x55cf8da14093 <unknown>
langchain-ai#17 0x7f3da31a72de start_thread
```

add option `chrome_options.add_argument("--no-sandbox")` for chrome.
Davis Chase (dev2049) pushed a commit that referenced this pull request May 10, 2023
Davis Chase (dev2049) pushed a commit that referenced this pull request May 17, 2023
…tor_to_weaviate

update class Weaviate (weaviate.py): add an attribute (by_text) to ch…
Harrison Chase (hwchase17) pushed a commit that referenced this pull request Jun 18, 2023
Davis Chase (dev2049) pushed a commit that referenced this pull request Jun 21, 2023
Davis Chase (dev2049) pushed a commit that referenced this pull request Jul 28, 2023
Isaiah Norton (ihnorton) referenced this pull request in ihnorton/langchain Sep 15, 2023
Add TileDB vectorstore implementation
Bagatur (baskaryan) pushed a commit that referenced this pull request Oct 6, 2023
Initial commit of rl_chain code
Prince Mendiratta (Prince-Mendiratta) pushed a commit to Prince-Mendiratta/langchain that referenced this pull request Oct 17, 2023
Akio Nishimura (akionux) pushed a commit to akionux/langchain that referenced this pull request Nov 7, 2023
ryanWang2018 pushed a commit to ryanWang2018/langchain that referenced this pull request Nov 29, 2023
Add IMDb base tool and movie search tool
Harrison Chase (hwchase17) pushed a commit that referenced this pull request Nov 30, 2023
@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

12 similar comments
@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing PR description...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing PR description...

7 similar comments
@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing PR description...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing PR description...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing PR description...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing PR description...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing PR description...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing PR description...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing PR description...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

PR Reviewer Guide 🔍

(Review updated until commit 270fc8d)

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Key issues to review

Code Smell
The StrictFormatter class does not handle the case where args is not empty and kwargs is empty. It only checks if args is not empty, but does not check if kwargs is empty.

Possible Bug
The Prompt class does not validate if the input_variables are actually used in the template. It only checks if the template is valid with dummy inputs.

Test Coverage
The tests for StrictFormatter do not cover all possible scenarios, such as testing with an empty template or with a template that has multiple placeholders.

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Persistent review updated to latest commit 270fc8d

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

3 similar comments
@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

@Arjun7A
Copy link

Arjun7A commented Mar 16, 2026

Preparing review...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants