fix bug 176: preserve YAML comments when reordering items by matching…#685
Merged
louislam merged 3 commits intolouislam:masterfrom Dec 31, 2024
Merged
fix bug 176: preserve YAML comments when reordering items by matching…#685louislam merged 3 commits intolouislam:masterfrom
louislam merged 3 commits intolouislam:masterfrom
Conversation
Owner
|
Thank you so much for fixing the issue! That was tough for me to fix. |
|
Hi, the latest stable docker image is one year old and doesn't include this fix. |
john-ho-codeonit-com
pushed a commit
to john-ho-codeonit-com/dockge
that referenced
this pull request
Feb 13, 2025
LucaDangeloS
pushed a commit
to LucaDangeloS/dockge
that referenced
this pull request
Apr 3, 2025
LucaDangeloS
pushed a commit
to LucaDangeloS/dockge
that referenced
this pull request
Apr 3, 2025
taylorbirdbumphealth
pushed a commit
to taylorbird/dockge
that referenced
this pull request
Jun 10, 2025
cfilipov
pushed a commit
to cfilipov/dockge
that referenced
this pull request
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… content instead of position
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md
Tick the checkbox if you understand [x]:
Description
Fixes #176
Current Behavior
Comments between array items (particularly in labels) are lost when entering edit mode because they're tied to array positions rather than content.
Fix Implementation
copyYAMLCommentsItemsincommon/util-common.tsType of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Take the following example, before the fix all comments on the label would be removed
After the fix, all comments remain attached to their items
My first ever PR so apologies if i've missed anything!