Skip to content

Switch back to npm#766

Merged
louislam merged 4 commits intomasterfrom
switch-back-to-npm
Mar 29, 2025
Merged

Switch back to npm#766
louislam merged 4 commits intomasterfrom
switch-back-to-npm

Conversation

@louislam
Copy link
Owner

The latest version of pnpm breaks things in this repo unfortunately. To keep it simpler, switching back to npm in order to save my time.

Read more:
https://socket.dev/blog/pnpm-10-0-0-blocks-lifecycle-scripts-by-default

@louislam louislam merged commit c62b916 into master Mar 29, 2025
2 checks passed
LucaDangeloS pushed a commit to LucaDangeloS/dockge that referenced this pull request Apr 3, 2025
LucaDangeloS pushed a commit to LucaDangeloS/dockge that referenced this pull request Apr 3, 2025
COPY --chown=node:node ./pnpm-lock.yaml ./pnpm-lock.yaml
RUN --mount=type=cache,id=pnpm,target=/pnpm/store pnpm install --prod --frozen-lockfile
COPY --chown=node:node ./package-lock.json ./package-lock.json
RUN npm ci
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added an extra 200MB to the image size because now you're installing development dependencies too.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your report, going to fix it later.

@KaelWD
Copy link

KaelWD commented Apr 14, 2025

Instead of npm install pnpm -g you could use corepack to lock it to 9.15

taylorbirdbumphealth pushed a commit to taylorbird/dockge that referenced this pull request Jun 10, 2025
KaelWD added a commit to KaelWD/dockge that referenced this pull request Jun 13, 2025
cfilipov pushed a commit to cfilipov/dockge that referenced this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants