Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Durable Task’s generated Python protobuf bindings to match the latest microsoft/durabletask-protobuf definitions, and adds repo guidance for regenerating these files going forward.
Changes:
- Regenerated
orchestrator_service_pb2.py/.pyifrom newer proto definitions (addsWorkItemFiltersand related filter messages). - Updated
PROTO_SOURCE_COMMIT_HASHto the new upstream source commit. - Added an agent skill doc for regeneration and ignored the
.proto_venvregeneration venv.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| durabletask/internal/orchestrator_service_pb2.pyi | Updates type stubs to include new workItemFilters and filter message types. |
| durabletask/internal/orchestrator_service_pb2.py | Updates generated protobuf descriptor / serialized offsets to match latest proto. |
| durabletask/internal/PROTO_SOURCE_COMMIT_HASH | Points to the new upstream durabletask-protobuf commit hash. |
| .gitignore | Ignores .proto_venv used for protobuf regeneration. |
| .github/skills/update-protobuf/SKILL.md | Documents repeatable steps to download proto and regenerate Python outputs. |
sophiatev
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update protobuf definitions to latest
Updates generated protobuf files to the latest
microsoft/durabletask-protobufdefinitions (
1caadbd).Also adds a Copilot agent skill (
.github/skills/update-protobuf/SKILL.md)for regenerating these files in the future, and adds
.proto_venvto.gitignore.