Merged
Conversation
Fix various warnings which show up when compiling with gcc. For the most part this doesn't change any semantics -- the only user-facing change is a bug fix in `Printer::Stringify` caused by a missing `return`.
Codecov ReportBase: 73.54% // Head: 73.18% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 73.54% 73.18% -0.37%
==========================================
Files 34 34
Lines 5072 5071 -1
==========================================
- Hits 3730 3711 -19
- Misses 1342 1360 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kvakil
added a commit
to kvakil/llnode
that referenced
this pull request
Sep 24, 2022
This test failed a couple of times in nodejs#415 and nodejs#417, so let's skip it for now.
kvakil
added a commit
to kvakil/llnode
that referenced
this pull request
Sep 24, 2022
This test failed a couple of times in nodejs#415, nodejs#417 and nodejs#418, so let's skip it for now.
kvakil
added a commit
to kvakil/llnode
that referenced
this pull request
Sep 24, 2022
This test failed a couple of times in nodejs#415, nodejs#417 and nodejs#418, so let's skip it for now.
Member
|
LGTM - I'm rerunning the the flaky tests and then I'll land it. |
No9
approved these changes
Sep 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various warnings which show up when compiling with gcc. For the most part this doesn't change any semantics -- the only user-facing change is a bug fix in
Printer::Stringifycaused by a missingreturn.