Add String::New overload for string_view

[cacharle]

Fixes #1703

[cacharle]

I added the New overload for Symbol aswell. I looked at other functions that take const char* but there is way too many of them and I don't want to unnecessarily bloat the code / break something so let me know if there is other place which could benefit from this overload

[legendecas]

Would you mind adding a test case in https://github.com/nodejs/node-addon-api/blob/main/test/name.cc? Thank you!

[legendecas]

I added the New overload for Symbol aswell. I looked at other functions that take const char* but there is way too many of them and I don't want to unnecessarily bloat the code / break something so let me know if there is other place which could benefit from this overload

Sounds good! we can start with these two sites.

[cacharle]

Same as #1705, the test take too long to compile, not sure how to run them

[legendecas]

@cacharle I added a doc about building with ninja to speed up local builds: #1709

[KevinEady]

Guards for c++17 can be removed.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.61%. Comparing base (86a0524) to head (9deb2e2).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
napi-inl.h	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1706      +/-   ##
==========================================
+ Coverage   63.50%   63.61%   +0.11%     
==========================================
  Files           3        3              
  Lines        2047     2056       +9     
  Branches      728      729       +1     
==========================================
+ Hits         1300     1308       +8     
  Misses        162      162              
- Partials      585      586       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cacharle]

Should be good now

Thanks for finishing #1704 for me btw, life got in the way