Skip to content

test: use realpath for NODE_TEST_DIR in common.js#10723

Closed
gibfahn wants to merge 2 commits intonodejs:masterfrom
gibfahn:common-testroot
Closed

test: use realpath for NODE_TEST_DIR in common.js#10723
gibfahn wants to merge 2 commits intonodejs:masterfrom
gibfahn:common-testroot

Conversation

@gibfahn
Copy link
Member

@gibfahn gibfahn commented Jan 10, 2017

If you don't specify NODE_TEST_DIR, common.tmpDir will resolve to the
realpath of node/test.

If you do specify NODE_TEST_DIR (with the environment variable or by
running tools/test.py --test-dir=x), common.tmpDir (which
is resolved from testRoot) uses the symbolic path (doesn't resolve
symlinks). This uses fs.realpathSync() to fix that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test, common

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants