test: use realpath for NODE_TEST_DIR in common.js#10723
Closed
gibfahn wants to merge 2 commits intonodejs:masterfrom
Closed
test: use realpath for NODE_TEST_DIR in common.js#10723gibfahn wants to merge 2 commits intonodejs:masterfrom
gibfahn wants to merge 2 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you don't specify
NODE_TEST_DIR,common.tmpDirwill resolve to therealpath of
node/test.If you do specify NODE_TEST_DIR (with the environment variable or by
running
tools/test.py --test-dir=x), common.tmpDir (whichis resolved from testRoot) uses the symbolic path (doesn't resolve
symlinks). This uses fs.realpathSync() to fix that.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, common