Skip to content

(backport) src/doc: improve man page and --help#10730

Closed
silverwind wants to merge 1 commit intonodejs:v7.x-stagingfrom
silverwind:backport-10157
Closed

(backport) src/doc: improve man page and --help#10730
silverwind wants to merge 1 commit intonodejs:v7.x-stagingfrom
silverwind:backport-10157

Conversation

@silverwind
Copy link
Copy Markdown
Contributor

@silverwind silverwind commented Jan 10, 2017

Backport of #10157 to v7.x-staging. cc: @evanlucas

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v7.x labels Jan 10, 2017
doc/node.1 Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have this flag on v7.x

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, missed to remove these here, will fix.

doc/node.1 Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have this flag either

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh! you're right! good catch

- add missing environment variables to --help
- add missing flags to man page
- sort environment variables alphabetically
- add some highlighting to the man page
- remove stops from descriptions in --help for consistency
- few other minor tweaks to --help

PR-URL: nodejs#10157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@silverwind
Copy link
Copy Markdown
Contributor Author

Fixed, thanks.

Copy link
Copy Markdown
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@silverwind silverwind changed the title src/doc: improve man page and --help (backport) src/doc: improve man page and --help Jan 12, 2017
.TP
.BR NODE_DISABLE_COLORS=1
When set to 1 colors will not be used in the REPL.
.BR NODE_EXTRA_CA_CERTS =\fIfile\fR
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this actually landed in v7 yet?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in v7.x-staging at least:

node/src/node.cc

Line 4539 in e07b651

if (const char* extra = secure_getenv("NODE_EXTRA_CA_CERTS"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in v7.x branch.

@silverwind
Copy link
Copy Markdown
Contributor Author

Landed on v7.x-staging: 61f6f12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants