Skip to content

test: skip the test with proper TAP message#11584

Closed
thefourtheye wants to merge 1 commit intonodejs:masterfrom
thefourtheye:skip-windows-test-setproctitle
Closed

test: skip the test with proper TAP message#11584
thefourtheye wants to merge 1 commit intonodejs:masterfrom
thefourtheye:skip-windows-test-setproctitle

Conversation

@thefourtheye
Copy link
Contributor

On Windows, the test simply returns which will be counted as passed.
The test actually skips the rest of the test. So proper TAP message has
to be included while skipping.

This patch uses common.skip rather than console.log to print the
skip messages.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants