deps/v8: add missing #include "unicode/normlzr.h"#13040
Closed
ArchangeGabriel wants to merge 1 commit intonodejs:v6.x-stagingfrom
ArchangeGabriel:patch-1
Closed
deps/v8: add missing #include "unicode/normlzr.h"#13040ArchangeGabriel wants to merge 1 commit intonodejs:v6.x-stagingfrom ArchangeGabriel:patch-1
ArchangeGabriel wants to merge 1 commit intonodejs:v6.x-stagingfrom
ArchangeGabriel:patch-1
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following function from <unicode/normlzr.h> is used:
normalize()
Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU.
Refs: #13022
P.S.: This is my first PR in Node, and my first “real” PR in any project, so I don’t expect it to be alright from the start.