Skip to content

deps: cherry-pick 866ee63 from upstream V8#13630

Closed
targos wants to merge 1 commit intonodejs:masterfrom
targos:backport-split-fix
Closed

deps: cherry-pick 866ee63 from upstream V8#13630
targos wants to merge 1 commit intonodejs:masterfrom
targos:backport-split-fix

Conversation

@targos
Copy link
Member

@targos targos commented Jun 12, 2017

Original commit message:

[string] Re-enable result caching for String.p.split

Runtime::kStringSplit's result caching is only enabled when limit equals
kMaxUInt32.

BUG=v8:6463

Review-Url: https://codereview.chromium.org/2923183002
Cr-Commit-Position: refs/heads/master@{#45724}

Fixes: #13445

@nodejs/v8

I did not update V8_PATCH_LEVEL because V8 5.9 is still supported.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants