doc: rephrase wording of child_process.execSync()#14953
Closed
ayazhafiz wants to merge 2 commits intonodejs:masterfrom
Closed
doc: rephrase wording of child_process.execSync()#14953ayazhafiz wants to merge 2 commits intonodejs:masterfrom
ayazhafiz wants to merge 2 commits intonodejs:masterfrom
Conversation
Rephrases the error thrown by child_process.execSync(). Fixes: nodejs#14944
nodejs-github-bot
added
child_process
lpinca
reviewed
Aug 20, 2017
doc/api/child_process.md
Outdated
| throw. The [`Error`][] object will contain the entire result from | ||
| [`child_process.spawnSync()`][] | ||
| throw an [`Error`][] that will include the full result of the underlying | ||
| [`spawnSync()`][]. |
Member
There was a problem hiding this comment.
I would keep the child_process. prefix for consistency.
Contributor
There was a problem hiding this comment.
considering this nit, rest all LGTM.
Contributor
Author
There was a problem hiding this comment.
agreed, should be fixed now!
daxlab
approved these changes
Aug 20, 2017
lpinca
approved these changes
Aug 20, 2017
jasnell
approved these changes
Aug 20, 2017
refack
approved these changes
Aug 20, 2017
cjihrig
approved these changes
Aug 20, 2017
Member
|
Landed in e76b1ff |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Aug 25, 2017
Rephrases the error thrown by child_process.execSync(). PR-URL: nodejs/node#14953 Fixes: nodejs/node#14944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 28, 2017
Rephrases the error thrown by child_process.execSync(). PR-URL: nodejs/node#14953 Fixes: nodejs/node#14944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rephrases the error thrown by child_process.execSync().
Fixes: #14944
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc