Skip to content

tools: update eslint to 9.9.1#54313

Closed
nodejs-github-bot wants to merge 2 commits intomainfrom
actions/tools-update-eslint
Closed

tools: update eslint to 9.9.1#54313
nodejs-github-bot wants to merge 2 commits intomainfrom
actions/tools-update-eslint

Conversation

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot commented Aug 11, 2024

This is an automated update of eslint to 9.9.1.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 11, 2024
@avivkeller
Copy link
Copy Markdown
Member

FWIW #54231 aims to remove ESlint locally and if it lands it'll conflict with this (and vise versa)

@nodejs-github-bot nodejs-github-bot changed the title tools: update eslint to 9.9.0 tools: update eslint to 9.9.1 Aug 25, 2024
@lpinca lpinca force-pushed the actions/tools-update-eslint branch from 28c6fe0 to 9648f10 Compare September 1, 2024 13:51
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2024
@lpinca lpinca force-pushed the actions/tools-update-eslint branch from 9648f10 to ebfeb00 Compare September 1, 2024 13:53
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2024

Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/10654633715

@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Sep 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2024
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (71b36b3) to head (b9f28c6).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54313      +/-   ##
==========================================
- Coverage   87.61%   87.60%   -0.02%     
==========================================
  Files         650      650              
  Lines      182834   182832       -2     
  Branches    35382    35384       +2     
==========================================
- Hits       160194   160169      -25     
- Misses      15925    15929       +4     
- Partials     6715     6734      +19     
Files with missing lines Coverage Δ
lib/internal/modules/esm/resolve.js 96.62% <ø> (-0.01%) ⬇️

... and 32 files with indirect coverage changes

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

@avivkeller avivkeller closed this Sep 6, 2024
@avivkeller
Copy link
Copy Markdown
Member

Closing, as the PR removing ESlint locally has landed. ESLint updates will now be handled by Dependabot.

@jakecastelli jakecastelli deleted the actions/tools-update-eslint branch March 19, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants