Skip to content

crypto: runtime-deprecate DEP0203 and DEP0204#62453

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:runtime-deprecate-crypto-key
Open

crypto: runtime-deprecate DEP0203 and DEP0204#62453
panva wants to merge 1 commit intonodejs:mainfrom
panva:runtime-deprecate-crypto-key

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Mar 27, 2026

Refs: #55293
Refs: #62321

@panva panva added crypto Issues and PRs related to the crypto subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Mar 27, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 27, 2026
@panva panva force-pushed the runtime-deprecate-crypto-key branch from 4c672c2 to 4412fe0 Compare March 27, 2026 07:53
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.70%. Comparing base (dbc7405) to head (4412fe0).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/crypto/keys.js 80.64% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62453      +/-   ##
==========================================
- Coverage   89.70%   89.70%   -0.01%     
==========================================
  Files         678      678              
  Lines      207192   207219      +27     
  Branches    39726    39729       +3     
==========================================
+ Hits       185865   185880      +15     
+ Misses      13443    13441       -2     
- Partials     7884     7898      +14     
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 95.81% <80.64%> (+<0.01%) ⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 28, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@panva
Copy link
Copy Markdown
Member Author

panva commented Mar 28, 2026

cc @nodejs/tsc for semver-major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants