test: wait for reattach before initial break on restart#62471
Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
Open
test: wait for reattach before initial break on restart#62471inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
jasnell
approved these changes
Mar 28, 2026
lpinca
approved these changes
Mar 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62471 +/- ##
==========================================
+ Coverage 89.70% 89.71% +0.01%
==========================================
Files 691 691
Lines 213935 213953 +18
Branches 41050 41043 -7
==========================================
+ Hits 191907 191948 +41
+ Misses 14095 14085 -10
+ Partials 7933 7920 -13 🚀 New features to boost your workflow:
|
fdb35b2 to
6c8f70e
Compare
UlisesGascon
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restartcan return to the prompt before the debugger reattaches and emits theinitial break. That leaves a race in these tests, which still flakes on macOS
unusual-path runs.
This change waits for
Debugger attached.and the prompt beforewaitForInitialBreak().CI failed logs:
Refs: #61762