Skip to content

test: wait for reattach before initial break on restart#62471

Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-restart-flaky-test
Open

test: wait for reattach before initial break on restart#62471
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-restart-flaky-test

Conversation

@inoway46
Copy link
Copy Markdown
Contributor

@inoway46 inoway46 commented Mar 28, 2026

restart can return to the prompt before the debugger reattaches and emits the
initial break. That leaves a race in these tests, which still flakes on macOS
unusual-path runs.

This change waits for Debugger attached. and the prompt before
waitForInitialBreak().

CI failed logs:

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 28, 2026
@inoway46 inoway46 marked this pull request as ready for review March 28, 2026 04:53
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (e78ccd8) to head (6c8f70e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62471      +/-   ##
==========================================
+ Coverage   89.70%   89.71%   +0.01%     
==========================================
  Files         691      691              
  Lines      213935   213953      +18     
  Branches    41050    41043       -7     
==========================================
+ Hits       191907   191948      +41     
+ Misses      14095    14085      -10     
+ Partials     7933     7920      -13     

see 51 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inoway46 inoway46 force-pushed the fix-restart-flaky-test branch from fdb35b2 to 6c8f70e Compare March 28, 2026 06:35
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants