Skip to content

crypto: add support for Ed25519 context parameter#62474

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:ed25519ctx-sign-verify
Open

crypto: add support for Ed25519 context parameter#62474
panva wants to merge 1 commit intonodejs:mainfrom
panva:ed25519ctx-sign-verify

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Mar 28, 2026

Extracted from #62345

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 28, 2026

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 28, 2026
@panva panva force-pushed the ed25519ctx-sign-verify branch from 8921f51 to a73d32d Compare March 28, 2026 10:29
@panva panva marked this pull request as ready for review March 28, 2026 10:30
@panva
crypto: add support for Ed25519 context parameter
dd20526 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva force-pushed the ed25519ctx-sign-verify branch from a73d32d to dd20526 Compare March 28, 2026 10:33
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (cf2b05c) to head (dd20526).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #62474   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files         691      691           
  Lines      213943   213943           
  Branches    41039    41039           
=======================================
+ Hits       191909   191920   +11     
- Misses      14089    14090    +1     
+ Partials     7945     7933   -12
Files with missing lines Coverage Δ
src/crypto/crypto_sig.cc 71.51% <ø> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jasnell
jasnell reviewed Mar 28, 2026
View reviewed changes
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 28, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 28, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72138/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panva @nodejs-github-bot @jasnell