lib: update outdated comment#8988
Closed
tanujasawant wants to merge 2 commits intonodejs:masterfrom
tanujasawant:master
Closed
lib: update outdated comment#8988tanujasawant wants to merge 2 commits intonodejs:masterfrom tanujasawant:master
tanujasawant wants to merge 2 commits intonodejs:masterfrom
tanujasawant:master
Conversation
nodejs-github-bot
added
the
child_process
Contributor
Author
|
from #8968 |
cjihrig
reviewed
Oct 9, 2016
lib/child_process.js
Outdated
| if (!Array.isArray(options.stdio)) { | ||
| // Leave stdin open for the IPC channel. stdout and stderr should be the | ||
| // same as the parent's if silent isn't set. | ||
| // Use a separate fd=3 for IPC channel. Inherit stdin, stdout, and stderr |
Contributor
There was a problem hiding this comment.
Please leave "the" in front of "IPC channel".
Contributor
There was a problem hiding this comment.
Yes, I mean please leave it as it was. In other words, have it say "for the IPC channel."
Contributor
Author
There was a problem hiding this comment.
Oh okay, thanks. It's done =)
Contributor
Author
|
@jasnell, when will this commit be merged into |
jasnell
pushed a commit
that referenced
this pull request
Oct 14, 2016
PR-URL: #8988 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Merged! Landed in 835fbee! Thank you @Tanuja-Sawant ! |
jasnell
pushed a commit
that referenced
this pull request
Oct 14, 2016
PR-URL: #8988 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
PR-URL: #8988 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
comments
Description of change
Updated an outdated comment in child_process.js to describe the code better.