timers: handle unrefed intervals in clearTimeout()#9606
Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
Closed
timers: handle unrefed intervals in clearTimeout()#9606cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
timers
Description of change
This commit clears the
_repeatproperty of all timer objects inclearTimeout(). This prevents intervals passed toclearTimeout()from being rearmed.Fixes: #9561 (although it does not directly address
wrap->object()issue described in #9561 (comment))R= @bnoordhuis