ext/standard: Use *_add instead of *_update for new keys in array_count_values#21530
Open
arshidkv12 wants to merge 1 commit intophp:masterfrom
Open
ext/standard: Use *_add instead of *_update for new keys in array_count_values#21530arshidkv12 wants to merge 1 commit intophp:masterfrom
arshidkv12 wants to merge 1 commit intophp:masterfrom
Conversation
arshidkv12
changed the title
Member
|
@arshidkv12 ... can you explain what your changes bring please ? |
iluuu1994
reviewed
Mar 25, 2026
| zval data; | ||
| ZVAL_LONG(&data, 1); | ||
| zend_hash_index_update(Z_ARRVAL_P(return_value), Z_LVAL_P(entry), &data); | ||
| zend_hash_index_add(Z_ARRVAL_P(return_value), Z_LVAL_P(entry), &data); |
Member
There was a problem hiding this comment.
If the intent is to generate better assembly, should be zend_hash_index_add_new() then I suppose?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.