Skip to content

gh-146440: Add "array_hook" parameter to JSON decoders#146441

Merged
vstinner merged 21 commits intopython:mainfrom
jsbueno:feature-json-array-hook
Mar 27, 2026
Merged

gh-146440: Add "array_hook" parameter to JSON decoders#146441
vstinner merged 21 commits intopython:mainfrom
jsbueno:feature-json-array-hook

Conversation

@jsbueno
Copy link
Contributor

@jsbueno jsbueno commented Mar 26, 2026

jsbueno added 2 commits March 25, 2026 22:55
     Add array_hook parameter, to both
     Python and C implementations
@bedevere-app
Copy link

bedevere-app bot commented Mar 26, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@jsbueno jsbueno changed the title Add json_array parameter to json.load and json.loads gh-146440: Add "array_hook" parameter to JSON decoders Mar 26, 2026
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is simple enough, and I have no strong objections, although I do not see an immerse need of this feature.

Please add a What's New entry.

@jsbueno jsbueno requested a review from AA-Turner as a code owner March 26, 2026 18:26
@jsbueno
Copy link
Contributor Author

jsbueno commented Mar 27, 2026

While we are at it, what about that flaky MacOS tkinter test? Can I just ignore it? Is there a place to re-run only it when it fails?

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It sounds like a reasonable addition for some specific use cases.

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner enabled auto-merge (squash) March 27, 2026 10:45
@vstinner
Copy link
Member

While we are at it, what about that flaky MacOS tkinter test? Can I just ignore it? Is there a place to re-run only it when it fails?

Core developers can re-run failing jobs to ignore flaky issues. The tkinter failure is a flaky test, it's unrelated to your change.

@vstinner vstinner merged commit d0061d5 into python:main Mar 27, 2026
52 checks passed
@vstinner
Copy link
Member

PR merged. Thanks for your nice contribution @jsbueno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants