gh-47005: fix do_open() to let regular headers override unredirected …#146506
Open
Das-Chinmay wants to merge 4 commits intopython:mainfrom
Open
gh-47005: fix do_open() to let regular headers override unredirected …#146506Das-Chinmay wants to merge 4 commits intopython:mainfrom
Das-Chinmay wants to merge 4 commits intopython:mainfrom
Conversation
…ected headers AbstractHTTPHandler.do_open() was building the request header dict by starting with unredirected_hdrs and only inserting regular headers that were not already present, giving unredirected headers priority. This contradicts get_header() and header_items(), both of which give regular headers the higher priority. Fix by unconditionally updating with req.headers so that a header set via add_header() always overrides one set via add_unredirected_header().
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractHTTPHandler.do_open()builds the outgoing header dict by startingwith
unredirected_hdrsand only merging regular headers that are notalready present — giving unredirected headers the higher priority.
This contradicts both
get_header()(checksself.headersfirst) andheader_items()({**unredirected_hdrs, **headers}), which both giveregular headers priority. The result: a header set via
add_header()issilently ignored if the same name was already set via
add_unredirected_header().Fix: replace the conditional merge with an unconditional
headers.update(req.headers).Fixes gh-47005