Closed
Conversation
|
@tiran, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @benjaminp, @malemburg and @tiran to be potential reviewers. |
Member
Author
|
Similar to pyca/cryptography#3612 |
Signed-off-by: Christian Heimes <christian@python.org>
serhiy-storchaka
approved these changes
Jun 15, 2017
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, but I suggest the patch that don't duplicate the code (see on the tracker).
vstinner
reviewed
Jul 25, 2017
| PyErr_NoMemory(); | ||
| goto fail; | ||
| } | ||
| buflen = OBJ_obj2txt(namebuf, buflen + 1, name, 0); |
Member
There was a problem hiding this comment.
Do we need that the new buflen is equal to the previous buflen?
Member
|
An alternate patch is provided as #2909. |
Member
Author
|
Closing in favor of #2909. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org