Update events and windows_events for asyncio in 3.14#14128
Merged
JelleZijlstra merged 11 commits intomainfrom May 25, 2025
Merged
Update events and windows_events for asyncio in 3.14#14128JelleZijlstra merged 11 commits intomainfrom
events and windows_events for asyncio in 3.14#14128JelleZijlstra merged 11 commits intomainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
sobolevn
changed the title
_DefaultEventLoopPolicy for asyncio in 3.14events and windows_events for asyncio in 3.14
This comment has been minimized.
This comment has been minimized.
sobolevn
force-pushed
the
asyncio-default-event-loop-policy
branch
from
afad6e1 to
9a3eb04
Compare
This comment has been minimized.
This comment has been minimized.
…m/python/typeshed into asyncio-default-event-loop-policy
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| "iscoroutinefunction", # from coroutines | ||
| "iscoroutine", # from coroutines | ||
| "AbstractEventLoopPolicy", # from events | ||
| "_AbstractEventLoopPolicy", # from events |
Member
There was a problem hiding this comment.
Having underscored names in __all__ seems wrong; maybe we should report over in CPython. Looks like it's not new in 3.14 though.
JelleZijlstra
approved these changes
May 24, 2025
Contributor
|
It looks like prefixing these items with underscores was just the way to implement deprecation warnings. They are still accessible under their usual names: https://github.com/python/cpython/blob/ebf955df7a89ed0c7968f79faec1de49f61ed7cb/Lib/asyncio/__init__.py#L54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source:
Refs python/cpython@a391d80#diff-4d950142ac4382096cb08d3d7f9b377ff8208085ce5d5f76ad0d0dadc7a77205