Skip to content

fix(notifications): auto-dismiss info-level workflow notifications #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Mar 25, 2026
Merged

fix(notifications): auto-dismiss info-level workflow notifications #3774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...sim/app/workspace/[workspaceId]/w/[workflowId]/components/notifications/notifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const ACTION_LABELS: Record<NotificationAction['type'], string> = {
} as const

function isAutoDismissable(n: Notification): boolean {
return n.level === 'error' && !!n.workflowId
return !!n.workflowId
}

function NotificationCountdownRing({ onPause }: { onPause: () => void }) {
Expand Down Expand Up @@ -54,7 +54,7 @@ function NotificationCountdownRing({ onPause }: { onPause: () => void }) {
* Positioned in the bottom-right workspace area, reactive to panel width and terminal height.
* Shows both global notifications and workflow-specific notifications.
*
* Workflow error notifications auto-dismiss after {@link AUTO_DISMISS_MS}ms with a countdown
* Workflow-scoped notifications auto-dismiss after {@link AUTO_DISMISS_MS}ms with a countdown
* ring. Clicking the ring pauses all timers until the notification stack clears.
*/
interface NotificationsProps {
Expand Down
Loading