Skip to content

feat(objectstorage): onboard compliance lock cmd#1351

Merged
rubenhoenle merged 2 commits intomainfrom
feat/STACKITCLI-341-object-storage-object-lock
Mar 26, 2026
Merged

feat(objectstorage): onboard compliance lock cmd#1351
rubenhoenle merged 2 commits intomainfrom
feat/STACKITCLI-341-object-storage-object-lock

Conversation

@rubenhoenle
Copy link
Member

@rubenhoenle rubenhoenle commented Mar 26, 2026

Description

relates to STACKITCLI-341

Testing instructions

Create compliance lock:

stackit object-storage compliance-lock lock

Describe compliance lock:

stackit object-storage compliance-lock describe

Delete compliance lock:

stackit object-storage compliance-lock unlock

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner March 26, 2026 15:55
@rubenhoenle rubenhoenle force-pushed the feat/STACKITCLI-341-object-storage-object-lock branch from fd56636 to 7278b0b Compare March 26, 2026 15:56
@rubenhoenle rubenhoenle force-pushed the feat/STACKITCLI-341-object-storage-object-lock branch from 7278b0b to c3e6602 Compare March 26, 2026 16:01
@rubenhoenle rubenhoenle self-assigned this Mar 26, 2026
cgoetz-inovex
cgoetz-inovex previously approved these changes Mar 26, 2026
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/describe 53.85% (+53.85%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/lock 35.71% (+35.71%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/unlock 27.03% (+27.03%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/compliance-lock.go 0.00% (ø) 6 (+6) 0 6 (+6)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/describe/describe.go 53.85% (+53.85%) 39 (+39) 21 (+21) 18 (+18) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/lock/lock.go 35.71% (+35.71%) 42 (+42) 15 (+15) 27 (+27) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/unlock/unlock.go 27.03% (+27.03%) 37 (+37) 10 (+10) 27 (+27) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/object_storage.go 0.00% (ø) 9 (+1) 0 9 (+1)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/lock/lock_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/unlock/unlock_test.go

@rubenhoenle rubenhoenle merged commit a1729da into main Mar 26, 2026
3 checks passed
@rubenhoenle rubenhoenle deleted the feat/STACKITCLI-341-object-storage-object-lock branch March 26, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants