feat: support customizable alignment for image display#1897
feat: support customizable alignment for image display#1897gaesa wants to merge 1 commit intosxyazi:mainfrom
Conversation
|
Thanks for the PR! Could you please just change the key parts and pull out the refactoring into a new PR? That would make the review a bit easier. |
Exposing `image_area` separately allows future Lua integration to handle image placement more flexibly, without needing to invoke full rendering. This change promotes modularity and simplifies obtaining image dimensions alone. This refactor provides the foundation for feature PR sxyazi#1897, preparing for easier integration.
2fad7d8 to
37a19b6
Compare
|
This PR currently introduces the ability to customize the alignment for image display by adding a third parameter to the
Next StepsOpen to feedback on improving specific implementation details or considering alternative approaches. |
f2e33da to
c65bdb3
Compare
2b70f8d to
5e48df5
Compare
43473db to
d72f903
Compare
4c5698d to
5058cf2
Compare
64a9bf2 to
4e96341
Compare
c14bbec to
7f17ecd
Compare
8872ea8 to
2d210ae
Compare
a9c693e to
86f4659
Compare
46c6cb0 to
4d589bd
Compare
This is an attempt to provide a possible solution to #1141.
yazi.tomlfor setting preferred image alignment, which plugin developers can optionally respect.PREVIEW.alignmentfor aligned image display.It appears to work well overall, though some aspects remain unclear:
serdealign with usual practices?