Skip to content

refactor!: remove unnecessary tasks_show and close_input commands#2530

Merged
sxyazi merged 1 commit intomainfrom
pr-45af3205
Mar 25, 2025
Merged

refactor!: remove unnecessary tasks_show and close_input commands#2530
sxyazi merged 1 commit intomainfrom
pr-45af3205

Conversation

@sxyazi
Copy link
Owner

@sxyazi sxyazi commented Mar 25, 2025

The tasks_show and close_input commands were introduced for cross-layer command invocation:

  • [manager] calls the [tasks]'s show command to open the task manager
  • [cmp] calls the [input]'s close command to close the input after completion

With #2399, Yazi now supports cross-layer command invocation in a more comprehensive and unified manner, making these two commands unnecessary.

⚠️ Breaking changes

tasks_show has been replaced by tasks:show:

# keymap.toml
[manager]
- { on = "w", run = "tasks_show" },
+ { on = "w", run = "tasks:show" },

close_input has been replaced by input:close:

# keymap.toml
[cmp]
- { on = "<Enter>", run = [ "close --submit", "close_input --submit" ] },
+ { on = "<Enter>", run = [ "close --submit", "input:close --submit" ] },

@sxyazi sxyazi merged commit aedfe76 into main Mar 25, 2025
6 checks passed
@sxyazi sxyazi deleted the pr-45af3205 branch March 25, 2025 09:37
Lemi0002 pushed a commit to Lemi0002/yazi that referenced this pull request Apr 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant