Skip to content

fix: don't fail on videos with embedded images#2590

Merged
sxyazi merged 1 commit intosxyazi:mainfrom
ze0987:yazi-v-p-2
Apr 8, 2025
Merged

fix: don't fail on videos with embedded images#2590
sxyazi merged 1 commit intosxyazi:mainfrom
ze0987:yazi-v-p-2

Conversation

@ze0987
Copy link
Contributor

@ze0987 ze0987 commented Apr 8, 2025

Currently, ffmpeg fails if video file contains embedded image.

[vf#0:1 @ 0x56848b4f5000] No filtered frames for output stream, trying to initialize anyway.
[mjpeg @ 0x75b41c45da40] Non full-range YUV is non-standard, set strict_std_compliance to at most unofficial to use it.
[mjpeg @ 0x56848b4e0280] ff_frame_thread_encoder_init failed
[vost#0:1/mjpeg @ 0x56848b4dffc0] Error while opening encoder - maybe incorrect parameters such as bit_rate, rate, width or height.
[vf#0:1 @ 0x56848b4e6f40] Task finished with error code: -22 (Invalid argument)
[vf#0:1 @ 0x56848b4e6f40] Terminating thread with return code -22 (Invalid argument)
[vost#0:1/mjpeg @ 0x56848b4dffc0] Could not open encoder before EOF
[vost#0:1/mjpeg @ 0x56848b4dffc0] Task finished with error code: -22 (Invalid argument)
[vost#0:1/mjpeg @ 0x56848b4dffc0] Terminating thread with return code -22 (Invalid argument)
[out#0/image2 @ 0x56848b29f240] Nothing was written into output file, because at least one of its streams received no packets.

Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sxyazi sxyazi changed the title fix: video - don't fail on videos w/ embedded images fix: don't fail on videos with embedded images Apr 8, 2025
@sxyazi sxyazi merged commit 99ea3b7 into sxyazi:main Apr 8, 2025
6 checks passed
@ze0987 ze0987 deleted the yazi-v-p-2 branch April 8, 2025 11:53
Lemi0002 pushed a commit to Lemi0002/yazi that referenced this pull request Apr 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants