feat: limit memory usage for previewing large images#2602
Merged
sxyazi merged 4 commits intosxyazi:mainfrom Apr 11, 2025
Merged
feat: limit memory usage for previewing large images#2602sxyazi merged 4 commits intosxyazi:mainfrom
sxyazi merged 4 commits intosxyazi:mainfrom
Conversation
Owner
|
I think this still makes sense, at the very least, it will not result in ImageMagick exhausting the memory and crashing the system, and it can serve as a temporary solution until we find a better way to limit ImageMagick's memory usage, so let's reopen it. |
sxyazi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2598This limits the memory available tomagick, but regardless,magicktries to scale the image anyway and fails. This is very wasteful, therefore it is not a solution.