Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces fine-grained behavior for the new peek and watch commands across multiple modules. Key changes include:
- Adding a new watch command in both the proxy and manager layers.
- Replacing several direct hover/peek calls with the new watch calls.
- Removing deprecated padding methods and element registrations.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yazi-proxy/src/mgr.rs | Added a new watch function to emit a watch command. |
| yazi-plugin/src/elements/rect.rs | Removed the deprecated padding method. |
| yazi-plugin/src/elements/elements.rs | Removed the deprecated "Padding" registration in element composition. |
| yazi-fm/src/executor.rs | Introduced watch event handling via on!(MGR, watch). |
| yazi-fm/src/app/commands/resize.rs | Added a call to peek(false) after hover. |
| yazi-core/src/tab/commands/sort.rs | Added peek(false) after calling hover for sort commands. |
| yazi-core/src/tab/commands/reveal.rs | Added peek(false) after hover; left a TODO comment for further review. |
| yazi-core/src/tab/commands/hidden.rs | Added peek(false) when hovered values change. |
| yazi-core/src/tab/commands/filter_do.rs | Added peek(false) after adjusting hover behavior in filtering. |
| yazi-core/src/tab/commands/arrow.rs | Added peek(false) after clearing hover in arrow commands. |
| yazi-core/src/mgr/commands/watch.rs | Introduced the new watch command implementation using a watcher. |
| yazi-core/src/mgr/commands/update_paged.rs | Updated opt conversion syntax and added a guard for empty targets. |
| yazi-core/src/mgr/commands/update_files.rs | Captured file revision to conditionally call hover, peek, and update_paged. |
| yazi-core/src/mgr/commands/refresh.rs | Replaced hover with watch(()) and added peek(false) in the refresh flow. |
| yazi-core/src/mgr/commands/mod.rs | Registered the new watch command. |
| yazi-core/src/mgr/commands/hover.rs | Replaced an inline peek call with a call to watch(()). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.