zephyr: idc: Name IDC p4wq threads#10656
Open
jsarha wants to merge 1 commit intothesofproject:mainfrom
Open
Conversation
Name IDC p4wq threads. Unfortunately the idc threads only get their names after they are needed for the first time. Until that time they appear as unnamed (a hex number) threads on core 0. There is also one funny thing. There is static thread reserved for core 0, but that is never activated, and it remains there as a hex number forever. However, in this simple and risk free convenience fix, I do not dare to touch that. Maybe later. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves runtime observability in the Zephyr IDC implementation by assigning deterministic names to the per-core IDC P4WQ threads, avoiding “unnamed/hex” thread entries in thread listings until first use.
Changes:
- Add per-core thread name construction in
idc_init_thread(). - Set the P4WQ static thread name via
k_thread_name_set()after enabling the static thread.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name IDC p4wq threads. Unfortunately the idc threads only get their names after they are needed for the first time. Until that time they appear as unnamed (a hex number) threads on core 0.
There is also one funny thing. There is static thread reserved for core 0, but that is never activated, and it remains there as a hex number forever.
However, in this simple and risk free convenience fix, I do not dare to touch that. Maybe later.