Skip to content

fix(flyout): align inline rename with non-rename styling#3811

Merged
waleedlatif1 merged 1 commit intostagingfrom
fix/flyout
Mar 27, 2026
Merged

fix(flyout): align inline rename with non-rename styling#3811
waleedlatif1 merged 1 commit intostagingfrom
fix/flyout

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • align inline rename with non-rename styling

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@cursor
Copy link
Copy Markdown

cursor bot commented Mar 27, 2026

PR Summary

Low Risk
Low risk UI-only change that adjusts layout/styling for the workflow inline-rename state without altering rename behavior or data flow.

Overview
Aligns the CollapsedWorkflowFlyoutItem inline rename UI with the non-edit row styling by wrapping the input in the same group/row container structure and updating padding/typography classes.

No functional changes to rename handling; this is a visual/layout consistency fix for the collapsed sidebar workflow flyout.

Written by Cursor Bugbot for commit bf406a7. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Mar 27, 2026 7:37pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 27, 2026

Greptile Summary

This PR fixes a visual inconsistency in CollapsedWorkflowFlyoutItem where the inline rename (edit) state had different styling than the normal (non-edit) row, by wrapping it in the same group relative outer div and aligning the inner class to use py-2 and text-caption instead of py-1.5 and text-[12px].\n\nKey changes:\n- The isEditing branch in CollapsedWorkflowFlyoutItem is restructured to mirror the two-level <div class=\"group relative\"> > <div …> pattern used by the non-edit branch.\n- Padding changed from py-1.5py-2 and font size from text-[12px]text-caption to match the non-editing row.\n- The shared EDIT_ROW_CLASS constant (still used by CollapsedTaskFlyoutItem) is no longer applied here — the workflow edit state now maintains its own inline class string consistent with the non-edit view.\n- CollapsedTaskFlyoutItem's edit branch was not updated and still uses the older EDIT_ROW_CLASS pattern, leaving a similar structural inconsistency there.

Confidence Score: 5/5

Safe to merge — purely a visual alignment fix with no logic changes or regressions.

All findings are P2 style/consistency suggestions. The change correctly achieves its stated goal of aligning the edit-state appearance with the non-edit row in CollapsedWorkflowFlyoutItem.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/collapsed-sidebar-menu/collapsed-sidebar-menu.tsx Wraps the CollapsedWorkflowFlyoutItem edit state in a group relative outer div and updates inner classes (py-2, text-caption) to match the non-edit row structure; CollapsedTaskFlyoutItem's parallel edit state retains the old EDIT_ROW_CLASS and structural mismatch.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CollapsedWorkflowFlyoutItem rendered] --> B{isEditing?}
    B -- Yes --> C["div.group.relative (new)"]
    C --> D["div bg-surface-active py-2 text-caption"]
    D --> E[WorkflowColorSwatch]
    D --> F[input element]
    B -- No --> G["div.group.relative"]
    G --> H["Link py-2 text-caption"]
    H --> I[WorkflowColorSwatch]
    H --> J[workflow.name span]
    G --> K[DropdownMenuSubTrigger More button]
Loading

Comments Outside Diff (1)

  1. apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/collapsed-sidebar-menu/collapsed-sidebar-menu.tsx, line 204-229 (link)

    P2 CollapsedTaskFlyoutItem edit state not updated to match

    The same styling inconsistency this PR fixes in CollapsedWorkflowFlyoutItem still exists in CollapsedTaskFlyoutItem. Its isEditing branch (lines 204–228) still:

    • Uses the shared EDIT_ROW_CLASS constant (which has py-1.5 and text-[12px]) instead of the new py-2 / text-caption alignment.
    • Does not wrap the edit row in an outer <div className='group relative'>, unlike its own non-edit branch (line 232).

    If the goal is consistent inline rename styling across both item types, CollapsedTaskFlyoutItem should receive the same structural update. The input class on line 215 also still specifies text-[12px] while the updated workflow input now uses text-caption.

Reviews (1): Last reviewed commit: "fix(flyout): align inline rename with no..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit fb233d0 into staging Mar 27, 2026
7 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/flyout branch March 27, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant